Discussion:
[PATCH] CLK: TI: Remove unused includes of linux/clk-private.h
Tomeu Vizoso
2014-10-03 15:51:59 UTC
Permalink
Signed-off-by: Tomeu Vizoso <***@collabora.com>
---
drivers/clk/ti/clk-44xx.c | 1 -
drivers/clk/ti/clk-54xx.c | 1 -
drivers/clk/ti/clk-7xx.c | 1 -
include/linux/clk/ti.h | 1 +
4 files changed, 1 insertion(+), 3 deletions(-)

diff --git a/drivers/clk/ti/clk-44xx.c b/drivers/clk/ti/clk-44xx.c
index 02517a8..8ea705e 100644
--- a/drivers/clk/ti/clk-44xx.c
+++ b/drivers/clk/ti/clk-44xx.c
@@ -12,7 +12,6 @@

#include <linux/kernel.h>
#include <linux/list.h>
-#include <linux/clk-private.h>
#include <linux/clkdev.h>
#include <linux/clk/ti.h>

diff --git a/drivers/clk/ti/clk-54xx.c b/drivers/clk/ti/clk-54xx.c
index 5e18399..e823d0b 100644
--- a/drivers/clk/ti/clk-54xx.c
+++ b/drivers/clk/ti/clk-54xx.c
@@ -12,7 +12,6 @@

#include <linux/kernel.h>
#include <linux/list.h>
-#include <linux/clk-private.h>
#include <linux/clkdev.h>
#include <linux/io.h>
#include <linux/clk/ti.h>
diff --git a/drivers/clk/ti/clk-7xx.c b/drivers/clk/ti/clk-7xx.c
index 62ac8f6..afd61a6 100644
--- a/drivers/clk/ti/clk-7xx.c
+++ b/drivers/clk/ti/clk-7xx.c
@@ -12,7 +12,6 @@

#include <linux/kernel.h>
#include <linux/list.h>
-#include <linux/clk-private.h>
#include <linux/clkdev.h>
#include <linux/clk/ti.h>

diff --git a/include/linux/clk/ti.h b/include/linux/clk/ti.h
index e8d8a35..ced953a 100644
--- a/include/linux/clk/ti.h
+++ b/include/linux/clk/ti.h
@@ -16,6 +16,7 @@
#define __LINUX_CLK_TI_H__

#include <linux/clkdev.h>
+#include <linux/clk-provider.h>

/**
* struct dpll_data - DPLL registers and integration data
--
1.9.3
Tero Kristo
2014-10-13 12:07:13 UTC
Permalink
Hi Tomeu,

Please add a changelog to this patch. Also, just replace the
clk-private.h includes with clk-provider.h, do not add the include to
the generic header. Rest of the kernel does that where needed.

Other than that, looks good to me.

-Tero
Post by Tomeu Vizoso
---
drivers/clk/ti/clk-44xx.c | 1 -
drivers/clk/ti/clk-54xx.c | 1 -
drivers/clk/ti/clk-7xx.c | 1 -
include/linux/clk/ti.h | 1 +
4 files changed, 1 insertion(+), 3 deletions(-)
diff --git a/drivers/clk/ti/clk-44xx.c b/drivers/clk/ti/clk-44xx.c
index 02517a8..8ea705e 100644
--- a/drivers/clk/ti/clk-44xx.c
+++ b/drivers/clk/ti/clk-44xx.c
@@ -12,7 +12,6 @@
#include <linux/kernel.h>
#include <linux/list.h>
-#include <linux/clk-private.h>
#include <linux/clkdev.h>
#include <linux/clk/ti.h>
diff --git a/drivers/clk/ti/clk-54xx.c b/drivers/clk/ti/clk-54xx.c
index 5e18399..e823d0b 100644
--- a/drivers/clk/ti/clk-54xx.c
+++ b/drivers/clk/ti/clk-54xx.c
@@ -12,7 +12,6 @@
#include <linux/kernel.h>
#include <linux/list.h>
-#include <linux/clk-private.h>
#include <linux/clkdev.h>
#include <linux/io.h>
#include <linux/clk/ti.h>
diff --git a/drivers/clk/ti/clk-7xx.c b/drivers/clk/ti/clk-7xx.c
index 62ac8f6..afd61a6 100644
--- a/drivers/clk/ti/clk-7xx.c
+++ b/drivers/clk/ti/clk-7xx.c
@@ -12,7 +12,6 @@
#include <linux/kernel.h>
#include <linux/list.h>
-#include <linux/clk-private.h>
#include <linux/clkdev.h>
#include <linux/clk/ti.h>
diff --git a/include/linux/clk/ti.h b/include/linux/clk/ti.h
index e8d8a35..ced953a 100644
--- a/include/linux/clk/ti.h
+++ b/include/linux/clk/ti.h
@@ -16,6 +16,7 @@
#define __LINUX_CLK_TI_H__
#include <linux/clkdev.h>
+#include <linux/clk-provider.h>
/**
* struct dpll_data - DPLL registers and integration data
Loading...